These were written by the developer's team when I joined Mainteny to give it to me.
Owned by @Windyasari Septriani
Component Standardization:
If done really well, can have 1-1 correspondence between design and code
Inappropriate use of variants (both typography and colors) to make the design look good.
- This will make development hard and code will be hard to read
- For example, a Card Text should be
typography/body, not typography/subtitle
- Also, for card background, setting
color/success seems inappropriate (it is not used in our file, though)
Lack of grid system
- Cards seem to have scattered randomly. To replicate this, developers would come up with some hacks which may be painful in the long run
- Can adopt a 12-column grid system. Developers can then use Grid components to develop the screens. This would also support responsiveness if the Grid component supports it.
Lack of standardization in terms of colors and typography
- Colors, once used in one context, should be used everywhere. Currently, this is not the case
- The same goes for typography
- This would make coding hard as developers have to define components/styles repeatedly
Lack of organization of Figma screens
- Hard to follow, find the required screen
- Consistent use of Auto layouts
- Hardcoding of values in some places makes things difficult
- Also, have to standardize where to define padding, etc
- Spacer components could be used for visual separation
- The typographical hierarchy is having too much variation in font sizes.
- Could use another ratio in the hierarchy, the current is around 1.411.
- Also, could eliminate some variants – be minimal – “less is more!”